Re: [PATCH rdma-rc] RDMA: Remove kernel private defines and reference to header from UAPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  #include <linux/types.h>
> -#include <rdma/ib_verbs.h>
> 
>  /*
>   * Increment this value if any changes that break userspace ABI
> @@ -548,11 +547,11 @@ enum {
>  };
> 
>  enum {
> -	IB_USER_LEGACY_LAST_QP_ATTR_MASK = IB_QP_DEST_QPN
> +	IB_USER_LEGACY_LAST_QP_ATTR_MASK = 1ULL << 20,
>  };
> 
>  enum {
> -	IB_USER_LAST_QP_ATTR_MASK = IB_QP_RATE_LIMIT
> +	IB_USER_LAST_QP_ATTR_MASK = 1ULL << 25,

I disagree with the upendcoding.  These constant should be moved to
the user verbs header instead.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux