On Tue, Feb 07, 2017 at 03:19:25PM -0700, Jason Gunthorpe wrote:
On Tue, Feb 07, 2017 at 02:06:30PM -0800, Vishwanathapura, Niranjana wrote:
>> IB_DEVICE_RAW_SCATTER_FCS = (1ULL << 34),
>>+ IB_DEVICE_RDMA_NETDEV_HFI_VNIC = (1ULL << 35),
>
>What is this called HFI_VNIC anyhow? Shouldn't this be OPA_VNIC? There
>is nothing really HFI specific, right?
Agreed, OPA_VNIC is more appropriate here. Will change it.
And probably lots of other places too.. :)
Well, our driver is called HFI1 and HFI_VNIC is in accordance with our naming
convention. I will only change the above device attribute name to OPA_VNIC in
the ib interface just to be consitant with other such defintions here.
>And this should be rn->dev_priv ?
Yah, both will result in same behavior. But yah, what you are suggesting
will remove any confusion. Will change in next PATCH series.
Only because the struct has no members, as soon as someone adds
something it would go booom.
Agreed.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
