> On Tue, Jan 24, 2017 at 09:02:55AM +0000, Amrani, Ram wrote:
> > > Don't you need to remove this lock from struct qedr_cq too?
> >
> > The CQ lock has other uses so it cannot be deleted.
>
> What do I miss here?
>
> Your patch removed all usages of this lock.
>
> ➜ linux-rdma git:(master) grep -rI comp_handler_lock drivers/infiniband/hw/qedr/*
> drivers/infiniband/hw/qedr/qedr_cm.c: spin_lock_irqsave(&cq->comp_handler_lock, flags);
> drivers/infiniband/hw/qedr/qedr_cm.c: spin_unlock_irqrestore(&cq->comp_handler_lock, flags);
> drivers/infiniband/hw/qedr/qedr_cm.c: spin_lock_irqsave(&cq->comp_handler_lock, flags);
> drivers/infiniband/hw/qedr/qedr_cm.c: spin_unlock_irqrestore(&cq->comp_handler_lock, flags);
> drivers/infiniband/hw/qedr/qedr.h: spinlock_t comp_handler_lock;
>
>
Yeah, you are right. I see now the other functionality isn't there.
I will re-issue the series.
Thanks!
Ram
��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
