Re: [PATCH 3/5] qedr: remove CQ spinlock from RDMA CM completion handlers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 24, 2017 at 09:02:55AM +0000, Amrani, Ram wrote:
> > Don't you need to remove this lock from struct qedr_cq too?
>
> The CQ lock has other uses so it cannot be deleted.

What do I miss here?

Your patch removed all usages of this lock.

➜  linux-rdma git:(master) grep -rI comp_handler_lock drivers/infiniband/hw/qedr/*
drivers/infiniband/hw/qedr/qedr_cm.c: spin_lock_irqsave(&cq->comp_handler_lock, flags);
drivers/infiniband/hw/qedr/qedr_cm.c: spin_unlock_irqrestore(&cq->comp_handler_lock, flags);
drivers/infiniband/hw/qedr/qedr_cm.c: spin_lock_irqsave(&cq->comp_handler_lock, flags);
drivers/infiniband/hw/qedr/qedr_cm.c: spin_unlock_irqrestore(&cq->comp_handler_lock, flags);
drivers/infiniband/hw/qedr/qedr.h:	spinlock_t comp_handler_lock;


>
> Thanks,
> Ram
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux