On Thu, Dec 22, 2016 at 01:15:55PM -0500, Doug Ledford wrote:
> On 12/22/2016 12:33 PM, Jason Gunthorpe wrote:
> > On Thu, Dec 22, 2016 at 02:17:52AM -0500, Jarod Wilson wrote:
> >>> %files -n librdmacm
> >>> %{_libdir}/librdmacm*.so.*
> >>> -%{_libdir}/rsocket/*.so.*
> >>> +%dir %{_libdir}/rsocket
> >>> +%{_libdir}/rsocket/*.so
> >>
> >> Minor error here, should be rsocket/*.so* to pick up the symlinks too, at
> >> least until they get neutered.
>
> I hand fixed this when taking the original series BTW...
>
> > FWIW, it would also be appropriate to put the LDPRELOAD library into
> > librdmacm-utils..
>
> I'm pretty sure the Fedora standards would want it in librsocket and not
> in a -utils package. The -utils package should be executables and not
> libraries.
Not sure, don't see anything about preload libraries. This is not a
link library, it is only executable via LD_PRELOAD, and it shouldn't
result in any automatic RPM Provides either (ditto for all our
plugins, I didn't check this).
Ideally there would be a 'run under rsockets' helper tool that did the
preload (ala fakeroot), and then it would be clear that the library is
a private data file of the helper and not a system link library.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
