Re: [PATCH rdma-core 5/6] redhat/spec: clean up rsocket packaging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/22/2016 12:33 PM, Jason Gunthorpe wrote:
> On Thu, Dec 22, 2016 at 02:17:52AM -0500, Jarod Wilson wrote:
>>> %files -n librdmacm
>>> %{_libdir}/librdmacm*.so.*
>>> -%{_libdir}/rsocket/*.so.*
>>> +%dir %{_libdir}/rsocket
>>> +%{_libdir}/rsocket/*.so
>>
>> Minor error here, should be rsocket/*.so* to pick up the symlinks too, at
>> least until they get neutered.

I hand fixed this when taking the original series BTW...

> FWIW, it would also be appropriate to put the LDPRELOAD library into
> librdmacm-utils..

I'm pretty sure the Fedora standards would want it in librsocket and not
in a -utils package.  The -utils package should be executables and not
libraries.


-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG Key ID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux