On 11/29/2016 9:33 PM, Tom Talpey wrote: > On 11/29/2016 9:07 PM, Doug Ledford wrote: >> On 11/28/2016 12:08 PM, Steve Wise wrote: >>>> >>>> On Sun, Nov 27, 2016 at 04:51:27PM +0200, Leon Romanovsky wrote: >>>> >>>>> +static inline bool rdma_protocol_raw_packet(const struct ib_device >>>>> *device, >>> u8 >>>> port_num) >>>>> +{ >>>>> + return device->port_immutable[port_num].core_cap_flags & >>>> RDMA_CORE_CAP_PROT_RAW_PACKET; >>>>> +} >>>> >>>> Does the mlx drivers really register ports with different capabilities >>>> as the same ib_device? I'm not sure that should be allowed. >>>> >>>> I keep talking about how we need to get rid of the port_num in these >>>> sorts of places because it makes no sense... >>>> >>> >>> I agree. Requiring the port number has implications that ripple up >>> into the >>> rdma-rw api as well... >>> >>> >> >> In all fairness, there is no requirement that any two ports on the same >> device be the same link layer, or if the link layer is Ethernet, there >> is no requirement that they can't support both iWARP and RoCE. The idea >> that the parent device defined the supported protocols for all ports of >> a device became wrong with the first mlx4 device that could do both IB >> and Ethernet. And I think I've heard rumblings of a combined RoCE/iWARP >> device possibly in the future from someone else. > > This one for instance? > > http://www.qlogic.com/Resources/Documents/DataSheets/Adapters/DataSheet_QLE45211HL_QLE45212HL.pdf > > > I'd love to see any such device support protocol choice per > connection, not just per port. That of course would have > implications on the rdma commection manager api. > That's certainly a prime example, thanks Tom ;-) -- Doug Ledford <dledford@xxxxxxxxxx> GPG Key ID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature