> On Nov 17, 2016, at 3:03 PM, Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> wrote: > >>> >>> On Nov 17, 2016, at 10:04 AM, Chuck Lever <chuck.lever@xxxxxxxxxx> wrote: >>> >>>> On Nov 17, 2016, at 7:46 AM, Christoph Hellwig <hch@xxxxxx> wrote: >>>> Also did you try to always register for > max_sge >>>> calls? The code can already register all segments with the >>>> rdma_rw_force_mr module option, so it would only need a small tweak for >>>> that behavior. >>> >>> For various reasons I decided the design should build one WR chain for >>> each RDMA segment provided by the client. Good clients expose just >>> one RDMA segment for the whole NFS READ payload. >>> >>> Does force_mr make the generic API use FRWR with RDMA Write? I had >>> assumed it changed only the behavior with RDMA Read. I'll try that >>> too, if RDMA Write can easily be made to use FRWR. >> >> Unfortunately, some RPC replies are formed from two or three >> discontiguous buffers. The gap test in ib_sg_to_pages returns >> a smaller number than sg_nents in this case, and rdma_rw_init_ctx >> fails. >> >> Thus with my current prototype I'm not able to test with FRWR. >> >> I could fix this in my prototype, but it would be nicer for me if >> rdma_rw_init_ctx handled this case the same for FRWR as it does >> for physical addressing, which doesn't seem to have any problem >> with a discontiguous SGL. > > Just to make sure I'm understanding you, for rdma-rw to handle this, it would > have to use multiple REG_MR registrations, one for each contiguous area in the > scatter list. > > Right? Right, that's the approach the NFS client takes. See net/sunrpc/xprtrdma/frwr_ops.c :: frwr_op_map. If the passed-in memory list isn't contiguous, frwr_op_map stops registering and returns to the caller, who allocates another MR and calls in again with the remaining part of the list. I think this would not apply to SG_GAP MRs, which should already be able to handle discontiguous SGLs? Note this doesn't apply to most NFS READs, where just the data payload is going via RDMA Write, and the payload is already in a contiguous piece of memory. But Reply chunks, which are used for READDIRs and other requests, can be built from discontiguous memory. I haven't looked closely at the RDMA Read logic, but I think it always reads into a contiguous set of pages, then builds the xdr_buf out of that. It shouldn't have the same problem (and it is already known to work with FRWR ;-). -- Chuck Lever -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
