> The patch 048867793046: "qedr: Add GSI support" from Oct 10, 2016, leads to > the following Smatch complaint: > > drivers/infiniband/hw/qedr/qedr_cm.c:284 qedr_gsi_build_header() > warn: variable dereferenced before check 'sgid_attr.ndev' (see line 281) > > drivers/infiniband/hw/qedr/qedr_cm.c > 280 > 281 vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev); > ^^^^^^^^^^^^^^ Dereference inside function. > > 282 if (vlan_id < VLAN_CFI_MASK) > 283 has_vlan = true; > 284 if (sgid_attr.ndev) > ^^^^^^^^^^^^^^ > Check too late. > > 285 dev_put(sgid_attr.ndev); > 286 Thanks Dan. I'll fix this. Ram -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
