[bug report] qedr: Add GSI support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Ram Amrani,

This is a semi-automatic email about new static checker warnings.

The patch 048867793046: "qedr: Add GSI support" from Oct 10, 2016, 
leads to the following Smatch complaint:

drivers/infiniband/hw/qedr/qedr_cm.c:284 qedr_gsi_build_header()
	 warn: variable dereferenced before check 'sgid_attr.ndev' (see line 281)

drivers/infiniband/hw/qedr/qedr_cm.c
   280	
   281		vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev);
                                                ^^^^^^^^^^^^^^
Dereference inside function.

   282		if (vlan_id < VLAN_CFI_MASK)
   283			has_vlan = true;
   284		if (sgid_attr.ndev)
                    ^^^^^^^^^^^^^^
Check too late.

   285			dev_put(sgid_attr.ndev);
   286	

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux