On Sun, Aug 28, 2016 at 06:50:56 -0700, Leon Romanovsky wrote: > On Sun, Aug 28, 2016 at 04:41:47PM +0300, Yuval Shaia wrote: > > On Sun, Aug 28, 2016 at 04:06:57PM +0300, Leon Romanovsky wrote: > > > On Thu, Aug 25, 2016 at 12:59:21PM +0300, Yuval Shaia wrote: > > > > On Wed, Aug 03, 2016 at 04:27:34PM -0700, Adit Ranadive wrote: > > > > > This patch adds the main device-level structures and functions to be used > > > > > to provide RDMA functionality. Also, we define conversion functions from > > > > > the IB core stack structures to the device-specific ones. > > > > > > > > > > Changes v2->v3: > > > > > - Removed VMware vendor id redefinition. > > > > > - Removed the boolean in pvrdma_cmd_post. > > > > > > > > > > Reviewed-by: Jorgen Hansen <jhansen@xxxxxxxxxx> > > > > > Reviewed-by: George Zhang <georgezhang@xxxxxxxxxx> > > > > > Reviewed-by: Aditya Sarwade <asarwade@xxxxxxxxxx> > > > > > Reviewed-by: Bryan Tan <bryantan@xxxxxxxxxx> > > > > > Signed-off-by: Adit Ranadive <aditr@xxxxxxxxxx> > > > > > --- > > > > > drivers/infiniband/hw/pvrdma/pvrdma.h | 456 ++++++++++++++++++++++++++++++++++ > > > > > 1 file changed, 456 insertions(+) > > > > > create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma.h > > > > > ... > > > > > + > > > > > +/* > > > > > + * VMware PVRDMA PCI device id. > > > > > + */ > > > > > +#define PCI_DEVICE_ID_VMWARE_PVRDMA 0x0820 > > > > > > > > I don't see a reason to define it locally in the driver. > > > > Suggesting to move it to include/linux/pci_ids.h > > > > > > Interesting, > > > We already discussed it. > > > > I believe the discussion was about vendor ID. > > As far as i see it - suggestion applies also to device ID. > > > > Yes, all PCI_DEVICE_ID_... defines are needed to be in pci_ids.h file. > > Thanks Looking at the header in pci_ids.h file we should only add it there if the definition will be shared between multiple drivers. That's not case for the PVRDMA device id so I believe this definition can stay here. I have moved the VMXNET3 device id there since we now use it in the PVRDMA driver too. Thanks, Adit -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
