On Sun, Aug 28, 2016 at 04:06:57PM +0300, Leon Romanovsky wrote: > On Thu, Aug 25, 2016 at 12:59:21PM +0300, Yuval Shaia wrote: > > On Wed, Aug 03, 2016 at 04:27:34PM -0700, Adit Ranadive wrote: > > > This patch adds the main device-level structures and functions to be used > > > to provide RDMA functionality. Also, we define conversion functions from > > > the IB core stack structures to the device-specific ones. > > > > > > Changes v2->v3: > > > - Removed VMware vendor id redefinition. > > > - Removed the boolean in pvrdma_cmd_post. > > > > > > Reviewed-by: Jorgen Hansen <jhansen@xxxxxxxxxx> > > > Reviewed-by: George Zhang <georgezhang@xxxxxxxxxx> > > > Reviewed-by: Aditya Sarwade <asarwade@xxxxxxxxxx> > > > Reviewed-by: Bryan Tan <bryantan@xxxxxxxxxx> > > > Signed-off-by: Adit Ranadive <aditr@xxxxxxxxxx> > > > --- > > > drivers/infiniband/hw/pvrdma/pvrdma.h | 456 ++++++++++++++++++++++++++++++++++ > > > 1 file changed, 456 insertions(+) > > > create mode 100644 drivers/infiniband/hw/pvrdma/pvrdma.h > > > > > > diff --git a/drivers/infiniband/hw/pvrdma/pvrdma.h b/drivers/infiniband/hw/pvrdma/pvrdma.h > > > new file mode 100644 > > > index 0000000..8a45fcc > > > --- /dev/null > > > +++ b/drivers/infiniband/hw/pvrdma/pvrdma.h > > > @@ -0,0 +1,456 @@ > > > +/* > > > + * Copyright (c) 2012-2016 VMware, Inc. All rights reserved. > > > + * > > > + * This program is free software; you can redistribute it and/or > > > + * modify it under the terms of EITHER the GNU General Public License > > > + * version 2 as published by the Free Software Foundation or the BSD > > > + * 2-Clause License. This program is distributed in the hope that it > > > + * will be useful, but WITHOUT ANY WARRANTY; WITHOUT EVEN THE IMPLIED > > > + * WARRANTY OF MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE. > > > + * See the GNU General Public License version 2 for more details at > > > + * http://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html. > > > + * > > > + * You should have received a copy of the GNU General Public License > > > + * along with this program available in the file COPYING in the main > > > + * directory of this source tree. > > > + * > > > + * The BSD 2-Clause License > > > + * > > > + * Redistribution and use in source and binary forms, with or > > > + * without modification, are permitted provided that the following > > > + * conditions are met: > > > + * > > > + * - Redistributions of source code must retain the above > > > + * copyright notice, this list of conditions and the following > > > + * disclaimer. > > > + * > > > + * - Redistributions in binary form must reproduce the above > > > + * copyright notice, this list of conditions and the following > > > + * disclaimer in the documentation and/or other materials > > > + * provided with the distribution. > > > + * > > > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > > > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > > > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS > > > + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE > > > + * COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, > > > + * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > > > + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR > > > + * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > > > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, > > > + * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > > > + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED > > > + * OF THE POSSIBILITY OF SUCH DAMAGE. > > > + */ > > > + > > > +#ifndef __PVRDMA_H__ > > > +#define __PVRDMA_H__ > > > + > > > +#include <linux/compiler.h> > > > +#include <linux/interrupt.h> > > > +#include <linux/list.h> > > > +#include <linux/mutex.h> > > > +#include <linux/pci.h> > > > +#include <linux/semaphore.h> > > > +#include <rdma/ib_umem.h> > > > +#include <rdma/ib_verbs.h> > > > + > > > +#include "pvrdma_defs.h" > > > +#include "pvrdma_dev_api.h" > > > +#include "pvrdma_verbs.h" > > > + > > > +/* NOT the same as BIT_MASK(). */ > > > +#define PVRDMA_MASK(n) ((n << 1) - 1) > > > + > > > +/* > > > + * VMware PVRDMA PCI device id. > > > + */ > > > +#define PCI_DEVICE_ID_VMWARE_PVRDMA 0x0820 > > > > I don't see a reason to define it locally in the driver. > > Suggesting to move it to include/linux/pci_ids.h > > Interesting, > We already discussed it. I believe the discussion was about vendor ID. As far as i see it - suggestion applies also to device ID. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
