Re: [RFC ABI V2 6/8] RDMA/core: Add initialize and cleanup of common types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20/07/2016 20:40, Jason Gunthorpe wrote:
On Tue, Jul 19, 2016 at 06:23:30PM +0300, Matan Barak wrote:
@@ -210,103 +211,9 @@ static void ib_uverbs_detach_umcast(struct ib_qp *qp,
 static int ib_uverbs_cleanup_ucontext(struct ib_uverbs_file *file,
 				      struct ib_ucontext *context)
 {
+	ib_uverbs_uobject_type_initialize_ucontext(context, &file->device->ib_dev->type_list);

There is a certain dissonance to having an initialize function called
inside a cleanup function - is that right (it doesn't look that
right)? If it is right, find a better name...


That's a bug, thanks.

Jason


Matan
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux