On Mon, Jul 18, 2016 at 11:19:21AM -0600, Jason Gunthorpe wrote:
> On Mon, Jul 18, 2016 at 12:40:48AM -0700, Yuval Shaia wrote:
> > Decouple SG support from HW ability to do UD checksum.
> > This coupling is for historical reasons and removed with 'commit
> > ec5f06156423 ("net: Kill link between CSUM and SG features.")'
>
> Shouldn't this also check that the QP's sg limit is something
> appropriate? At least > 1 ..
What is special with 1?
Network stack can pass MAX_SKB_FRAGS frags so even if QP's SG limit is 3 we
are still in problem.
Fortunately this was addressed in 'commit 78a50a5 ("Add handling for
sending of skb with many frags").
>
> Presumably things still work if the skb needs more sg's than are
> available?
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
