Re: [PATCH v1] IB/ipoib: Report SG feature regardless of HW UD CSUM capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 18, 2016 at 11:19:21AM -0600, Jason Gunthorpe wrote:
> On Mon, Jul 18, 2016 at 12:40:48AM -0700, Yuval Shaia wrote:
> > Decouple SG support from HW ability to do UD checksum.
> > This coupling is for historical reasons and removed with 'commit
> > ec5f06156423 ("net: Kill link between CSUM and SG features.")'
> 
> Shouldn't this also check that the QP's sg limit is something
> appropriate? At least > 1 ..
> 
> Presumably things still work if the skb needs more sg's than are
> available?

IMHO, this question is relevant for the code before change as well.

> 
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux