On 05/18/2016 12:47 AM, Leon Romanovsky wrote: > On Tue, May 17, 2016 at 10:58:19AM -0400, Doug Ledford wrote: >> On 05/17/2016 01:48 AM, Leon Romanovsky wrote: >>> On Mon, May 16, 2016 at 04:27:05PM -0400, Doug Ledford wrote: >> >>>> It's not removing two lines. If someone wants to be able to boot both >>>> kernels prior to this change and kernel post this change, they have to >>>> now write their script to handle both conditions sanely. And they have >>>> to know to do so, where as very often they simply get caught off guard >>>> and things are broken for some period of time. If the change to ib_addr >>>> actually solved a problem that couldn't be solved otherwise, that would >>>> be one thing. But it doesn't. It's a complete no-op. >>> >>> I think that your position is too tight for not allowing modules >>> restructure. It looks like that this complexity doesn't exist outside >>> testing scripts. >> >> No, they were/are production scripts. >> >>> For my testings, I'm using Debian Sid with inbox scripts/packages and it handles >>> correctly IB stack with different kernels and different set of modules. >> >> Does it support reloading the stack and have you tried it if it does? > > It is RedHat specific, from my understanding in other distribution there is no > special script to reload RDMA, I wrote for myself module reload script > for debug. Then I guess I was just nice to developers back in the day. -- Doug Ledford <dledford@xxxxxxxxxx> GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature