On Tue, May 17, 2016 at 12:00:39PM -0400, Doug Ledford wrote: > operation O(n^2). Since we can't break out mailbox commands to only > provide part of the data, I think we need to consider using a cached > struct for each device. If the cached data is less than a certain age > on subsequent reads, we use the cached data. If it's too old, we > discard it and get new data. I noticed this too, but for sysfs reading I just felt it doesn't matter. Ultimately a followup patch should export the entire stats block through netlink as one operation and nothing should use sysfs except debugging. Keeping the driver interface simple seems valuable. Caching is going to detrimental to apps that sync stats with external time. (which is almost every real-world app) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html