On 05/16/2016 09:52 AM, Christoph Lameter wrote:
> On Fri, 13 May 2016, Doug Ledford wrote:
>
>> I don't like this entire chunk. Please handle both the cxgb3 and cxgb4
>> changes like you did the mlx4 changes. Specifically, use an enum to
>> define the array index for names and an array of offsets so that the
>> textual names from the enum can be used to access the array. The way
>> things are here is horribly fragile.
>
> Ok but I cannot separate this out in a a distinct patch.
That's fine.
>> Secondly, do *not* use a BUG_ON in this patch. I saw at least two of
>> them. There is nothing in this patch so serious that we should crash
>> the kernel. Any failure here is something we can work around and keep
>> running.
>
> WARN_ON_ONCE then?
>
Yep.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature
