On 04/19/2016 02:38 PM, Christoph Hellwig wrote:
> On Tue, Apr 19, 2016 at 11:30:32AM -0600, Jason Gunthorpe wrote:
>> Right, this was done because rdma_protocol_iwarp takes a port number.
>>
>> I think we discussed this once, the core code doesn't actually support
>> different protocols on different ports, so the port_num argument to
>> rdma_protocol_iwarp is redundant.
>>
>> This all starts to look really goofy when multi-port APM is used and
>> the QP's port number changes dynamically at runtime. (I have some
>> experimental patches that do that), I'd rather see all the port_num
>> stuff in this series go away. :(
>
> Reall, I would _love_ to kill all that port_num crap. But until
> we get agreement from Doug and all the core maintainers that we
> can kill it from the core, and that multi-protocol devices are
> indeed as silly as they seem I can't..
>
No worries, the patchset (and the subsequent series you promised a few
emails later in this thread) can proceed ;-)
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature
