Re: [PATCH 02/12] IB/cma: pass the port number to ib_create_qp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




The new RW API will need this.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>
Tested-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>

I'm not opposed to this change but traditionally QPs are bound to a
device not to a single port.

Right, this was done because rdma_protocol_iwarp takes a port number.

I think we discussed this once, the core code doesn't actually support
different protocols on different ports, so the port_num argument to
rdma_protocol_iwarp is redundant.

This all starts to look really goofy when multi-port APM is used and
the QP's port number changes dynamically at runtime. (I have some
experimental patches that do that), I'd rather see all the port_num
stuff in this series go away. :(

HCH and I complained about this per-port distinction in several private
conversations. I'd really love to see it go away too.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux