On Fri, Dec 18, 2015 at 10:08:41AM +0200, Or Gerlitz wrote: > On 12/17/2015 7:41 PM, Jason Gunthorpe wrote: > >On Thu, Dec 17, 2015 at 03:44:19PM +0200, Sagi Grimberg wrote: > >>>+ ret = ib_query_device(device, &device->attrs); > >>>+ if (ret) { > >>>+ printk(KERN_WARNING "Couldn't query the device attributes\n"); > >>>+ goto out; > >>>+ } > >>>+ > >>I thought we're all for removing the call altogether aren't we? > >> > >>I'd say just call device->query_device() instead. > >Christoph's patch even got rid of device->query_device(), > > Wrong. Not really, lots of hunks in Christoph's patch are removing query_device ie: @@ -1305,7 +1299,6 @@ int mthca_register_device(struct mthca_dev *dev) dev->ib_dev.phys_port_cnt = dev->limits.num_ports; dev->ib_dev.num_comp_vectors = 1; dev->ib_dev.dma_device = &dev->pdev->dev; - dev->ib_dev.query_device = mthca_query_device; dev->ib_dev.query_port = mthca_query_port; Sure, it sticks around in a couple places but it isn't 'query_device' anymore, it is 'query_device_udata' which is reasonable. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html