On Thu, Dec 17, 2015 at 03:44:19PM +0200, Sagi Grimberg wrote:
>
> >+ ret = ib_query_device(device, &device->attrs);
> >+ if (ret) {
> >+ printk(KERN_WARNING "Couldn't query the device attributes\n");
> >+ goto out;
> >+ }
> >+
>
> I thought we're all for removing the call altogether aren't we?
>
> I'd say just call device->query_device() instead.
Christoph's patch even got rid of device->query_device(), which, IHMO,
I prefer to see over this. It re-enforces that these values are
constants and drivers cannot change them on the fly.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
