On Tue, Dec 08, 2015 at 03:02:44PM -0800, Christoph Hellwig wrote: > On Tue, Dec 08, 2015 at 03:59:40PM -0700, Jason Gunthorpe wrote: > > Or, can we please stop this bikeshedding. Christoph's patch is done, > > well tested and does a lot more clean up that this hacky three liner. > > > > It is a good patch, and although patchworks doesn't have my remarks > > from an earlier revision I still think it should go forward. > > While I'd prefer the version Or points to over not having anything > at all I'd much prefer sorting it properly and make the RDMA code > behave like all other Linux subsystems. *shrug* as long as we get the purge of ib_query_device and the assocaited migration of the driver code to the register function, I don't care very much what the names are either. device->max_map_per_fmr vs device->attr.max_map_per_fmr is just bikeshedding. > Jason, can you give me a formal ACK'ed by and I'll rebase it on top > of the current 4.4 queue so we could start the 4.5 window with it. I looked over the version in patchworks again, looks OK to me: Reviewed-by: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> Thanks, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
