On Mon, Dec 07, 2015 at 02:39:04PM -0700, Jason Gunthorpe wrote: > On Mon, Dec 07, 2015 at 09:26:11PM +0000, Hefty, Sean wrote: > > > +static int rvt_query_device(struct ib_device *ibdev, > > > + struct ib_device_attr *props, > > > + struct ib_udata *uhw) > > > +{ > > > + /* > > > + * Return rvt_dev_info.props contents > > > + */ > > > + return -EINVAL; > > > > ENOSYS on all of the function templates. This and subsequent patches. > > We recently had a long discussion about what the correct answer here > is. > > ENOSYS and EINVAL are both wrong for different reasons.. Can't recall > if something else was settled on? I think I was suggesting one of the > ENOTSUP varients? You suggested EOPNOTSUPP [1] [1] http://www.spinics.net/lists/linux-rdma/msg30176.html > > Jason > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html