Re: [PATCH 06/37] IB/rdmavt: Add query and modify device stubs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 07, 2015 at 09:26:11PM +0000, Hefty, Sean wrote:
> > +static int rvt_query_device(struct ib_device *ibdev,
> > +			    struct ib_device_attr *props,
> > +			    struct ib_udata *uhw)
> > +{
> > +	/*
> > +	 * Return rvt_dev_info.props contents
> > +	 */
> > +	return -EINVAL;
> 
> ENOSYS on all of the function templates.  This and subsequent patches.

We recently had a long discussion about what the correct answer here
is.

ENOSYS and EINVAL are both wrong for different reasons.. Can't recall
if something else was settled on? I think I was suggesting one of the
ENOTSUP varients?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux