On Tue, Nov 24, 2015 at 12:04:36PM +0200, Sagi Grimberg wrote: > Jason and Or, > > > > >I'm with Or on this, this is really goofy looking. > > > >This routine probably should not be setting the rkey at all, it makes > >no sense to have a routine that returns a lkey and a rkey. Those are > >always different flows. > > > >Once that is fixed then the above if can be hoisted to the actual > >calling code that needs an rkey, at the point where it does something > >different when !iser_always_reg is true.. > > This change is acceptable to me. However, given that it includes > rework outside the scope of this specific patch which is a performance > regression fix, would it be acceptable to have it incremental and > provide a FIXME comment here? I'm not bothered by the ordering as long as we are clear where things are going :) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
