On Tue, Oct 20, 2015 at 7:52 PM, Jason Gunthorpe wrote: > On Tue, Oct 20, 2015 at 07:42:25PM +0300, Or Gerlitz wrote: >> As for the RoCE patches, you mentioned reviewing them, this is going to >> take time, which makes sense. However, the self-multicast loopback prevention >> patches are > > My issue with the latest round of UAPI changes is I don't see any > Reviewed-By tag from someone at Mellanox whom I think understands our > UAPI. > > UAPI changes are *NOT* something first-time list contributors should > be doing unassisted. Jason, your point makes sense, when we did the internal review, I have asked that someone with the relevant knowledge will review this part. As I wrote below, we should encourage people to take part in upstream development, and making such comment only after the patch sits on the list whole two months (V1 was very minor change, V2 was re-spin) isn't going in the encouragement direction. There's one patch in the series that adds UAPI -- it's 1/7 "IB/core: Extend ib_uverbs_create_qp" https://patchwork.kernel.org/patch/7405241/ I will try to get Reviewed-by: from Haggai or Matan tomorrow, can you also take a look today, so we don't miss 4.4 just for that? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
