On 07/31/2015 03:34 AM, Christoph Hellwig wrote:
> On Fri, Jul 31, 2015 at 02:05:06AM +0300, Or Gerlitz wrote:
>> So... enough is enough, please put it in a kernel module residing in
>> the IB core and use it in this driver, to begin with. The fact that
>> ipath is going to go, makes the cope duplication "only" 2X vs the 3X,
>> but it's still 2X
>
> Agreed. Any if anyone tries to submit software RoCE again it'll be
> another duplication.
Or, I haven't looked at the soft-roce driver (ever). Is it going to
need this library as well? If it is, then as you have rung the bell for
getting this library written, I will expect Mellanox to work with Intel
to make sure that this library is suitable for not just their hardware
drivers but also the soft-roce driver you guys are working on. I might
even suggest that it's time to work up the soft-roce submission sooner
rather than later in light of what I've done with the hfi1 driver.
On that note, Mike, I've taken the hfi1 driver into my tree, but I moved
it to the staging tree. There, I created a TODO file with these items
from the review:
July, 2015
- Remove unneeded file entries in sysfs
- Remove software processing of IB protocol and place in library for use
by qib, ipath (if still present), hfi1, and eventually soft-roce
- Clean up comments in code around CNP opcode
You will note that I have not placed "rework the /dev/ipath file
write/writev semantics" on that list. I have yet to hear a convincing
technical reason that this must be done so I won't require it (you are
free to do so, however, if you just want to quite down the noise). That
might change on the basis of any further emails in the thread.
So my plan here is that we will move the driver out of staging once
we've gotten these items taken care of. However, I will note this
specific item: if the soft-roce driver needs the library too, and it is
not yet in a state to be submitted and even not in a state where its
needs can be articulated clearly so that the library can be written with
soft-roce's needs in mind as well as the Intel driver's needs, then I'll
let the hfi1 driver out of staging before that task is complete and
we'll just get to the library when we have all of the stake holders in
place and can actually work on all of them at once.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature
