On 07/31/2015 03:31 AM, Christoph Hellwig wrote:
> On Thu, Jul 30, 2015 at 05:42:16PM -0400, Doug Ledford wrote:
>> I have no problem with this code. That Al finds the user space ABI for
>> this driver to be bizarre is neither here nor there to me. Sure, this
>> file does not exhibit normal file API behavior. Who cares?
>
> Everyone who cares about filesystem semantics does.
If this were a filesystem and this were its file semantics, that would
be all kinds of screwed up. But this is a private character special device.
> A NACK from me for a this features,
If you have a legitimate technical reason to NACK this feature, make
your case. I've publicly stated, in response to Al no less, that I
don't see justification for making a team re-engineer a working, private
interface because a disinterested third party finds it "weird". If you
provide no valid technical justification for your NACK, I'm going to
disregard it.
> and b) for trying to sneak it in
> after a negative comment without cc to -fsdevel and Al.
Not that I was trying to "sneak it in", but that's neither here nor
there, you Cc:ed Al for me, and we already had our discussion (unless Al
wishes to come back and say more, he so far has allowed me to have the
last word).
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: 0E572FDD
Attachment:
signature.asc
Description: OpenPGP digital signature
