Re: [PATCH] libibverbs init.c: remove stderr warnings if no userspace driver found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On May 11, 2015, at 2:32 PM, Yann Droneaud <ydroneaud@xxxxxxxxxx> wrote:
> 
> (I have to find some information about this libfabric which is already
> released as 1.0.0 version).

See http://ofiwg.github.io/libfabric/ (and the corresponding code https://github.com/ofiwg/libfabric).

>> That is: it's not a warning or an error if libibverbs cannot find a
>> userspace driver for kernel devices.  Indeed, returning a num_devices
>> of 0 is sufficient -- the middleware shouldn't be unconditionally
>> printing out stderr message; let the upper layer application do that
>> (if it wants to).
> 
> This paragraph should definitively be part of your commit message.

Ok.

>> FWIW, Sean just removed a similar set of stderr warnings from librdmacm:
>> 
>>   http://git.openfabrics.org/?p=~shefty/librdmacm.git;a=commitdiff;h=2b2aad809afc56fa3157f5cf99036f92b9c90f16
> 
> I don't think this a good thing to remove all the error messages
> unconditionally. It could have been made a build option + an environment
> variable option to help mere mortals to debug their setups.

Ok.  v3 coming shortly.

-- 
Jeff Squyres
jsquyres@xxxxxxxxx
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux