Re: [PATCH] libibverbs init.c: remove stderr warnings if no userspace driver found

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On May 9, 2015, at 8:04 AM, Yann Droneaud <ydroneaud@xxxxxxxxxx> wrote:
> 
> Le vendredi 08 mai 2015 à 11:21 -0700, Jeff Squyres a écrit :
>> Signed-off-by: Jeff Squyres <jsquyres@xxxxxxxxx>
> 
> This is a little short for an explanation: what was the issue with the
> error messages ?

Cisco has stopped shipping its libibverbs usnic driver, although we are still using the kernel driver in the /sys/class/infiniband space (since it's the only way to be upstream).  Specifically: instead of using libibverbs for userspace access, we are now using libfabric.

That is: it's not a warning or an error if libibverbs cannot find a userspace driver for kernel devices.  Indeed, returning a num_devices of 0 is sufficient -- the middleware shouldn't be unconditionally printing out stderr message; let the upper layer application do that (if it wants to).

FWIW, Sean just removed a similar set of stderr warnings from librdmacm:

   http://git.openfabrics.org/?p=~shefty/librdmacm.git;a=commitdiff;h=2b2aad809afc56fa3157f5cf99036f92b9c90f16

>> -		free(sysfs_dev);
> 
> I believe this free() was necessary to not leak some memory.

Ah -- I mis-read the loop.  I'll re-submit with the loop still there, but just removing the fprintf block.

-- 
Jeff Squyres
jsquyres@xxxxxxxxx
For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/

��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux