> On Aug 18, 2014, at 5:52 AM, Devesh Sharma <Devesh.Sharma@xxxxxxxxxx> wrote: > > Hi Chuk, > > Can this patch be lined up for merger. Looks like there are no oppositions to this change Sorry, I was expecting a fresh rewritten patch. I haven't done a deep review of the original. Anything you want to merge should be independently tested, of course. For example Steve should include it in his testing branch. > > -Regards > Devesh > >> -----Original Message----- >> From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Devesh Sharma >> Sent: Thursday, July 31, 2014 10:45 AM >> To: Chuck Lever >> Cc: Steve Wise; Shirley Ma; Hefty, Sean; Roland Dreier; linux- >> rdma@xxxxxxxxxxxxxxx >> Subject: RE: [for-next 1/2] xprtrdma: take reference of rdma provider >> module >> >>> -----Original Message----- >>> From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- >>> owner@xxxxxxxxxxxxxxx] On Behalf Of Chuck Lever >>> Sent: Thursday, July 31, 2014 12:09 AM >>> To: Devesh Sharma >>> Cc: Steve Wise; Shirley Ma; Hefty, Sean; Roland Dreier; linux- >>> rdma@xxxxxxxxxxxxxxx >>> Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider >>> module >>> >>> >>> On Jul 22, 2014, at 1:06 AM, Devesh Sharma >> <Devesh.Sharma@xxxxxxxxxx> >>> wrote: >>> >>>>> -----Original Message----- >>>>> From: Chuck Lever [mailto:chuck.lever@xxxxxxxxxx] >>>>> Sent: Monday, July 21, 2014 11:01 PM >>>>> To: Devesh Sharma >>>>> Cc: Steve Wise; Shirley Ma; Hefty, Sean; Roland Dreier; linux- >>>>> rdma@xxxxxxxxxxxxxxx >>>>> Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma >>>>> provider module >>>>> >>>>> >>>>> On Jul 21, 2014, at 1:07 PM, Devesh Sharma >>> <Devesh.Sharma@xxxxxxxxxx> >>>>> wrote: >>>>> >>>>>>>>>> Until that support is in place, obviously I would prefer that >>>>>>>>>> the removal of the underlying driver be prevented while there >>>>>>>>>> are NFS mounts in place. I think that's what NFS users have >>>>>>>>>> come to >>> expect. >>>>>>>>>> >>>>>>>>>> In other words, don't allow device removal until we have >>>>>>>>>> support for device insertion :-) >>>>>> >>>>>> This needs a fresh series of patches? >>>>> >>>>> "do not allow removal" would likely take an approach similar to >>>>> what you originally posted, unless someone has an idea how to use a >>>>> CM_EVENT to make this work, or there is an objection from the >>>>> kernel >>> RDMA folks. >>>> >>>> Okay, I will re-work the patch if need be. >>> >>> Devesh, if there isn't one already, could you file an upstream bug at >>> >>> http://bugzilla.linux-nfs.org >>> >>> that documents the shutdown hang and perhaps summarizes this thread? >>> Thanks! >> >> A bug has been filed >> https://bugzilla.linux-nfs.org/show_bug.cgi?id=266 >> >>> >>> -- >>> Chuck Lever >>> chuck[dot]lever[at]oracle[dot]com >>> >>> >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" >>> in the body of a message to majordomo@xxxxxxxxxxxxxxx More >> majordomo >>> info at http://vger.kernel.org/majordomo-info.html >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the >> body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at >> http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
