On Fri, 7 Mar 2025 12:57:19 +0100 Sebastian Andrzej Siewior wrote: > The mlx5 driver supports per-channel statistics. To make support generic > it is required to have a template to fill the individual channel/ queue. > > Provide page_pool_ethtool_stats_get_strings_mq() to fill the strings for > multiple queue. Sorry to say this is useless as a common helper, you should move it to mlx5. The page pool stats have a standard interface, they are exposed over netlink. If my grep-foo isn't failing me no driver uses the exact strings mlx5 uses. "New drivers" are not supposed to add these stats to ethtool -S, and should just steer users towards the netlink stats. IOW mlx5 is and will remain the only user of this helper forever. -- pw-bot: cr
