On Thu, Nov 7, 2024 at 3:23 AM Gal Pressman <gal@xxxxxxxxxx> wrote: > > On 06/11/2024 13:49, Yafang Shao wrote: > > On Wed, Nov 6, 2024 at 5:56 PM Tariq Toukan <ttoukan.linux@xxxxxxxxx> wrote: > >> > >> > >> > >> On 06/11/2024 8:40, Yafang Shao wrote: > >>> We observed a high number of rx_discards_phy events on some servers when > >>> running `ethtool -S`. However, this important counter is not currently > >>> reflected in the /proc/net/dev statistics file, making it challenging to > >>> monitor effectively. > >>> > >>> Since rx_missed_errors represents packets dropped due to buffer exhaustion, > >>> it makes sense to include rx_discards_phy in this counter to enhance > >>> monitoring visibility. This change will help administrators track these > >>> events more effectively through standard interfaces. > >>> > >> > >> Hi, > >> > >> Thanks for your patch. > >> > >> It's a matter of interpretation... > >> The documentation in > >> Documentation/ABI/testing/sysfs-class-net-statistics refers to the > >> driver for the exact meaning. > > I think this documentation is outdated, a more recent one is in if_link.h: Should we sync the documentation in if_link.h with Documentation/ABI/testing/sysfs-class-net-statistics? -- Regards Yafang
