On Wed, Nov 6, 2024 at 5:56 PM Tariq Toukan <ttoukan.linux@xxxxxxxxx> wrote: > > > > On 06/11/2024 8:40, Yafang Shao wrote: > > We observed a high number of rx_discards_phy events on some servers when > > running `ethtool -S`. However, this important counter is not currently > > reflected in the /proc/net/dev statistics file, making it challenging to > > monitor effectively. > > > > Since rx_missed_errors represents packets dropped due to buffer exhaustion, > > it makes sense to include rx_discards_phy in this counter to enhance > > monitoring visibility. This change will help administrators track these > > events more effectively through standard interfaces. > > > > Hi, > > Thanks for your patch. > > It's a matter of interpretation... > The documentation in > Documentation/ABI/testing/sysfs-class-net-statistics refers to the > driver for the exact meaning. > > rx_discards_phy counts packet drops due to exhaustion of the physical > port memory (not in the host), this happen way before steering the > packet to any receive queue. > Today, rx_missed_errors counts SW/host memory buffer exhaustion of the > receive queues. > I don't think that rx_missed_errors should mix both. Thanks for your detailed explanation. > > Maybe some other counter can be used for rx_discards_phy, like > rx_fifo_errors? It appears that rx_fifo_errors is a more appropriate counter for this purpose. I will submit a v2. Thanks for your suggestion. -- Regards Yafang
