On 2024-09-19 20:40:48 +0300, Moshe Shemesh wrote: > > > On 9/19/2024 8:24 PM, Mohamed Khalfella wrote: > > > > On 2024-09-04 20:38:13 -0700, Mohamed Khalfella wrote: > >> On 2024-08-30 12:51:43 +0300, Moshe Shemesh wrote: > >>> > >>> > >>> On 8/30/2024 10:08 AM, Przemek Kitszel wrote: > >>> > >>>> > >>>> On 8/30/24 01:58, Mohamed Khalfella wrote: > >>>>> On 2024-08-29 15:38:55 -0600, Mohamed Khalfella wrote: > >>>>>> Changes in v2: > >>>>>> - Removed cond_resched() in mlx5_vsc_wait_on_flag(). The idea is that > >>>>>> usleep_range() should be enough. > >>>>>> - Updated cond_resched() in mlx5_vsc_gw_read_block_fast every 128 > >>>>>> iterations. > >>>>>> > >>>>>> v1: > >>>>>> https://lore.kernel.org/all/20240819214259.38259-1-mkhalfella@xxxxxxxxxxxxxxx/ > >>>>>> > >>>>>> Mohamed Khalfella (1): > >>>>>> net/mlx5: Added cond_resched() to crdump collection > >>>>>> > >>>>>> drivers/net/ethernet/mellanox/mlx5/core/lib/pci_vsc.c | 4 ++++ > >>>>>> 1 file changed, 4 insertions(+) > >>>>>> > >>>>>> -- > >>>>>> 2.45.2 > >>>>>> > >>>>> > >>>>> Some how I missed to add reviewers were on v1 of this patch. > >>>>> > >>>> > >>>> You did it right, there is need to provide explicit tag, just engaging > >>>> in the discussion is not enough. v2 is fine, so: > >>>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx> > >>> > >>> Reviewed-by: Moshe Shemesh <moshe@xxxxxxxxxx> > >>> And fixes tag should be: > >>> Fixes: 8b9d8baae1de ("net/mlx5: Add Crdump support") > >> > >> Will add the tag in v3. > > > > A quick follow up on this patch. I posted v3 [1] of this patch with > > minor changes. There are no functional differences between v2 and v3 of > > this patch. The commit messsage on v3 has information why call > > cond_resched() every 128 iterations, so that could be useful to add. > > > > Is there anything I need to do to get v2 or v3 of this patch merged? > > I already added my reviewed-by tag on this patch you can see up here, > same goes to v3. > Thanks. Thank you.
