Re: [PATCH v2 0/1] net/mlx5: Added cond_resched() to crdump collection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 8/30/2024 10:08 AM, Przemek Kitszel wrote:


On 8/30/24 01:58, Mohamed Khalfella wrote:
On 2024-08-29 15:38:55 -0600, Mohamed Khalfella wrote:
Changes in v2:
- Removed cond_resched() in mlx5_vsc_wait_on_flag(). The idea is that
   usleep_range() should be enough.
- Updated cond_resched() in mlx5_vsc_gw_read_block_fast every 128
   iterations.

v1: https://lore.kernel.org/all/20240819214259.38259-1-mkhalfella@xxxxxxxxxxxxxxx/

Mohamed Khalfella (1):
   net/mlx5: Added cond_resched() to crdump collection

  drivers/net/ethernet/mellanox/mlx5/core/lib/pci_vsc.c | 4 ++++
  1 file changed, 4 insertions(+)

--
2.45.2


Some how I missed to add reviewers were on v1 of this patch.


You did it right, there is need to provide explicit tag, just engaging
in the discussion is not enough. v2 is fine, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>

Reviewed-by: Moshe Shemesh <moshe@xxxxxxxxxx>
And fixes tag should be:
Fixes: 8b9d8baae1de ("net/mlx5: Add Crdump support")

Thanks.




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux