On Thu, Jun 27, 2024 at 09:43:20PM +0300, Leon Romanovsky wrote: > On Thu, Jun 27, 2024 at 07:57:17PM +0300, Margolin, Michael wrote: > > > > On 6/26/2024 6:38 PM, Jason Gunthorpe wrote: > > > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > > > > > > > > > On Mon, Jun 24, 2024 at 04:09:18PM +0000, Michael Margolin wrote: > > > > Name functions that aren't exposed outside of a file with '_' prefix and > > > > make sure that all verbs ops' implementations are named according to the > > > > op name with an additional 'efa_' prefix. > > > That isn't the kernel convention, please don't use _ like this > > > > > > Jason > > > > AFAIK there is no single kernel convention for static functions naming and > > it also seems that the underscore prefix isn't rare in the subsystem. > > Underscore at the beginning of the function name is a common practice > to mark that function as locked variant. Yeah, it is not typical to mark static functions at all. You might exclude the symbol prefix (like efa_) but even that is not universal. Jason
