Re: [PATCH for-next 5/5] RDMA/efa: Align private func names to a single convention

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 6/26/2024 6:38 PM, Jason Gunthorpe wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.



On Mon, Jun 24, 2024 at 04:09:18PM +0000, Michael Margolin wrote:
Name functions that aren't exposed outside of a file with '_' prefix and
make sure that all verbs ops' implementations are named according to the
op name with an additional 'efa_' prefix.
That isn't the kernel convention, please don't use _ like this

Jason

AFAIK there is no single kernel convention for static functions naming and it also seems that the underscore prefix isn't rare in the subsystem.

Would you suggest a preferred style?


Michael





[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux