On 6/19/24 00:19, Stephen Hemminger wrote: > On Tue, 18 Jun 2024 19:37:36 +0000 > Omer Shpigelman <oshpigelman@xxxxxxxxx> wrote: > >>> >>> Is there any reason in particular to call netif_receive_skb instead of >>> napi_gro_receive ? >>> >> >> As you can see, we also support polling mode which is a non-NAPI flow. >> We could use napi_gro_receive() for NAPI flow and netif_receive_skb() for >> polling mode but we don't support RX checksum offload anyway. > > Why non-NAPI? I thought current netdev policy was all drivers should > use NAPI. If that's the current policy then I can remove this non-NAPI mode. I see on another thread that module parameters are not allowed so apparently I'll need to remove this polling mode anyway as it is set by a module parameter.
