On Mon, Jun 17, 2024 at 05:10:03PM -0300, Jason Gunthorpe wrote:
> On Mon, Jun 17, 2024 at 06:49:47PM +0300, Leon Romanovsky wrote:
> > On Mon, Jun 17, 2024 at 10:44:09AM -0300, Jason Gunthorpe wrote:
> > > On Sun, Jun 16, 2024 at 07:15:57PM +0300, Leon Romanovsky wrote:
> > >
> > > > @@ -63,6 +63,7 @@ enum uverbs_default_objects {
> > > > enum {
> > > > UVERBS_ATTR_UHW_IN = UVERBS_UDATA_DRIVER_DATA_FLAG,
> > > > UVERBS_ATTR_UHW_OUT,
> > > > + UVERBS_ATTR_UHW_DRIVER_DATA,
> > >
> > > The start of the driver's attributes is not a "UHW", the UHW is only
> > > the old structs.
> >
> > I asked from Akiva to keep existing naming convention UVERBS_ATTR_UHW_XXX
> > to emphasize the namespace and the position of this attribute as
> > relevant for existing UHW calls.
>
> Well, calling it DRIVER_DATA and UHW is very confusing when it is
> really the start of the indexing for drivers that use UHW.
>
> A better name is needed
UVERBS_ATTR_UHW_PRIVATE ????
>
> Jason
>
