Re: [PATCH rdma-next 1/2] RDMA: Pass entire uverbs attr bundle to create cq function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 17, 2024 at 10:44:09AM -0300, Jason Gunthorpe wrote:
> On Sun, Jun 16, 2024 at 07:15:57PM +0300, Leon Romanovsky wrote:
> 
> > @@ -63,6 +63,7 @@ enum uverbs_default_objects {
> >  enum {
> >  	UVERBS_ATTR_UHW_IN = UVERBS_UDATA_DRIVER_DATA_FLAG,
> >  	UVERBS_ATTR_UHW_OUT,
> > +	UVERBS_ATTR_UHW_DRIVER_DATA,
> 
> The start of the driver's attributes is not a "UHW", the UHW is only
> the old structs.

I asked from Akiva to keep existing naming convention UVERBS_ATTR_UHW_XXX
to emphasize the namespace and the position of this attribute as
relevant for existing UHW calls.

> 
> Something like UVERBS_ATTR_DRIVER_NS_WITH_UHW

I think that my proposed name is better.

Thanks

> 
> Jason




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux