> -----Original Message----- > From: David Hildenbrand [mailto:david@xxxxxxxxxx] > Sent: Tuesday, June 4, 2024 10:02 PM > To: Gonglei (Arei) <arei.gonglei@xxxxxxxxxx>; qemu-devel@xxxxxxxxxx > Cc: peterx@xxxxxxxxxx; yu.zhang@xxxxxxxxx; mgalaxy@xxxxxxxxxx; > elmar.gerdes@xxxxxxxxx; zhengchuan <zhengchuan@xxxxxxxxxx>; > berrange@xxxxxxxxxx; armbru@xxxxxxxxxx; lizhijian@xxxxxxxxxxx; > pbonzini@xxxxxxxxxx; mst@xxxxxxxxxx; Xiexiangyou > <xiexiangyou@xxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; lixiao (H) > <lixiao91@xxxxxxxxxx>; jinpu.wang@xxxxxxxxx; Wangjialin > <wangjialin23@xxxxxxxxxx> > Subject: Re: [PATCH 1/6] migration: remove RDMA live migration temporarily > > On 04.06.24 14:14, Gonglei via wrote: > > From: Jialin Wang <wangjialin23@xxxxxxxxxx> > > > > The new RDMA live migration will be introduced in the upcoming few > > commits. > > > > Signed-off-by: Jialin Wang <wangjialin23@xxxxxxxxxx> > > Signed-off-by: Gonglei <arei.gonglei@xxxxxxxxxx> > > --- > > [...] > > > - > > - /* Avoid ram_block_discard_disable(), cannot change during migration. > */ > > - if (ram_block_discard_is_required()) { > > - error_setg(errp, "RDMA: cannot disable RAM discard"); > > - return; > > - } > > I'm particularly interested in the interaction with virtio-balloon/virtio-mem. > > Do we still have to disable discarding of RAM, and where would you do that in > the rewrite? > Yes, we do. We didn't change the logic. Thanks for your catching. Regards, -Gonglei > -- > Cheers, > > David / dhildenb
