On Fri, Feb 16, 2024 at 01:09:10PM +0100, Niklas Schnelle wrote: > On Thu, 2024-01-18 at 16:59 +0100, Niklas Schnelle wrote: > > On Thu, 2024-01-18 at 10:00 -0400, Jason Gunthorpe wrote: > > > On Thu, Jan 18, 2024 at 02:46:40PM +0100, Niklas Schnelle wrote: > > > > > > > Yes, we need zpci_memcpy_toio(to, from, count * 8) since our count is > > > > in bytes like for memcpy_toio(). > > > > > > https://github.com/jgunthorpe/linux/commits/mlx5_wc/ > > > > > > Jason > > > > > > > Thanks, the s390 patches: > > > > > > s390: Implement __iowrite32_copy() > > s390: Use the correct count for __iowrite64_copy() > > s390: Stop using weak symbols for __iowrite64_copy() > > > > Look good to me. I.e. you may add my. > > > > Acked-by Niklas Schnelle <schnelle@xxxxxxxxxxxxx> > > > > I did test your patches too and by accident confirmed again that these > > do need commit 80df7d6af7f6 ("s390/pci: fix max size calculation in > > zpci_memcpy_toio()") from the s390 feature branch to get the mlx5 > > driver to detect Write-Combining as supported. Note, as far as I know > > Alexander Gordeev is targeting that one for v6.8-rc2 since we had quite > > a few changes for v6.8-rc1. > > Since I haven't seen a new version of this yet I was just wondering > what the current plan is. If this is somewhat stuck would you be > willing to send the "s390: Use the correct count for > __iowrite64_copy()" patch separately, preferably with "s390/pci:" > prefix? I have been waiting for test cycles on the right ARM64 system and it is taking a long time :( I'll send your bit so you can take it to -rc Thanks, Jason
