On 09/01/2024 17:20, Greg Sword wrote: > On Tue, Jan 9, 2024 at 4:41 PM Li Zhijian <lizhijian@xxxxxxxxxxx> wrote: >> >> commit 9ac01f434a1e ("RDMA/rxe: Extend dbg log messages to err and info") >> newly added this info. But it did only show null device when >> the rdma_rxe is being loaded because dev_name(rxe->ib_dev->dev) >> has not yet been assigned at the moment: >> >> "(null): rxe_set_mtu: Set mtu to 1024" >> >> Remove it to silent this message, check the mtu from it backend link >> instead if needed. >> >> CC: Bob Pearson <rpearsonhpe@xxxxxxxxx> >> Signed-off-by: Li Zhijian <lizhijian@xxxxxxxxxxx> >> --- >> V4: Remove it rather than re-order rxe_set_mtu() and rxe_register_device() >> --- >> drivers/infiniband/sw/rxe/rxe.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c >> index a086d588e159..ae466e72fc43 100644 >> --- a/drivers/infiniband/sw/rxe/rxe.c >> +++ b/drivers/infiniband/sw/rxe/rxe.c >> @@ -160,8 +160,6 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu) >> >> port->attr.active_mtu = mtu; >> port->mtu_cap = ib_mtu_enum_to_int(mtu); >> - >> - rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap); > > I'd like to keep this statement so I can tell if the mtu setup was > successful or not. During the module loading, once it's loaded successfully, the mtu is set as well. The another caller rxe_notify()->rxe_set_mtu() already had its own dbg message for this, people can enable the dbg if needed. Anyway, I'm open to your point. Thanks Zhijian > >> } >> >> /* called by ifc layer to create new rxe device. >> -- >> 2.29.2 >> >>