> -----Original Message-----
> From: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
> Sent: Wednesday, November 29, 2023 4:24 AM
> To: Bernard Metzler <BMT@xxxxxxxxxxxxxx>; jgg@xxxxxxxx; leon@xxxxxxxxxx
> Cc: linux-rdma@xxxxxxxxxxxxxxx; guoqing.jiang@xxxxxxxxx
> Subject: [EXTERNAL] [PATCH 1/4] RDMA/siw: Move tx_cpu ahead
>
> We can reduce one cacheline for the usage of struct siw_qp.
>
> Before,
>
> /* size: 1928, cachelines: 31, members: 38 */
> /* sum members: 1920, holes: 2, sum holes: 8 */
> /* paddings: 4, sum paddings: 13 */
> /* forced alignments: 3 */
>
> after
>
> /* size: 1920, cachelines: 30, members: 38 */
> /* paddings: 4, sum paddings: 13 */
> /* forced alignments: 3 */
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@xxxxxxxxx>
> ---
> drivers/infiniband/sw/siw/siw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/siw/siw.h
> b/drivers/infiniband/sw/siw/siw.h
> index b36d1ec25327..d14bb965af75 100644
> --- a/drivers/infiniband/sw/siw/siw.h
> +++ b/drivers/infiniband/sw/siw/siw.h
> @@ -417,10 +417,10 @@ struct siw_iwarp_tx {
> struct siw_qp {
> struct ib_qp base_qp;
> struct siw_device *sdev;
> + int tx_cpu;
> struct kref ref;
> struct completion qp_free;
> struct list_head devq;
> - int tx_cpu;
> struct siw_qp_attrs attrs;
>
> struct siw_cep *cep;
> --
> 2.35.3
Looks good.
Acked-by: Bernard Metzler <bmt@xxxxxxxxxxxxxx>
