From: Jakub Kicinski <kuba@xxxxxxxxxx> Date: Fri, 21 Jul 2023 18:29:42 -0700 > On Fri, 21 Jul 2023 17:51:17 +0200 Alexander Lobakin wrote: >>>> More specificly, yon means the below, right? >>>> include/net/page_pool.h >>>> include/net/page_pool/types.h >>> >>> Yes. >> >> What I meant is >> >> include/net/page_pool/types.h >> include/net/page_pool/driver.h >> >> I'm not insisting, just to be clear :) > > I thought we already talked about naming headers after the user :S > Unless you're _defining_ a driver in driver.h that's not a good name. > types.h, helpers.h, functions.h, dma.h are good names. Ah, sure :) I was mostly talking about include/net/page_pool.h include/net/page_pool/types.h vs include/net/page_pool/helpers.h (or functions.h) include/net/page_pool/types.h I.e. whether to have a header with the same name next to the folder or place everything in that folder. Thanks, Olek
