> From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
> Sent: Tuesday, March 28, 2023 10:25 AM
> To: Dexuan Cui <decui@xxxxxxxxxxxxx>
> ...
> On Tue, Mar 28, 2023 at 05:38:59AM +0000, Dexuan Cui wrote:
> > > From: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxx>
> > > Sent: Monday, March 27, 2023 10:29 PM
> > > > ...
> > > > ---
> >
> > Please note this special line "---".
> > Anything after the special line and before the line "diff --git" is discarded
> > automaticaly by 'git' and 'patch'.
> >
> > > > drivers/pci/controller/pci-hyperv.c | 13 +++++++++++++
> > > > 1 file changed, 13 insertions(+)
> > > >
> > > > @@ -3635,6 +3641,8 @@ static int hv_pci_probe(struct hv_device *hdev,
> > > >
> > > > retry:
> > > > ret = hv_pci_query_relations(hdev);
> > > > + printk("hv_pci_query_relations() exited\n");
> > >
> > > Can we use pr_* or the appropriate KERN_<LEVEL> in all the printk(s).
> >
> > This is not part of the real patch :-)
> > I just thought the debug code can help understand the issues
> > resolved by the patches.
> > I'll remove the debug code to avoid confusion if I need to post v2.
>
> I guess that means you *will* post a v2, right?
I guess I didn't make myself clear, sorry. The "debug code" is not
part of the real patch body -- if we run the "patch" program or "git am"
to apply the patches, the "debug code" is automatically dropped because
it's between the special "---" line and the real start of the patch body (i.e.
the "diff --git" line).
So far, IMO I don't have to post v2 because the patch body and the patch
description (except for the part that's automatically removed by 'patch'
and 'git') don't need any change.
> Or do you expect
> somebody else to remove the debug code? If you do keep any debug or
> other logging, use pci_info() (or dev_info()) whenever possible.
As I explained above, 'patch' and 'git' automatically remove the part that
don't have to be in the git history.
>
> Also capitalize the subject line to match the others in the series.
>
> Bjorn
Thanks for catching this! If this is the only thing to be fixed, I hope the
PCI folks can help fix this when accepting the patch. If you think I should
post v2, please let me know.
