On Tue, Mar 28, 2023 at 05:38:59AM +0000, Dexuan Cui wrote:
> > From: Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxx>
> > Sent: Monday, March 27, 2023 10:29 PM
> > > ...
> > > ---
>
> Please note this special line "---".
> Anything after the special line and before the line "diff --git" is discarded
> automaticaly by 'git' and 'patch'.
>
> > > drivers/pci/controller/pci-hyperv.c | 13 +++++++++++++
> > > 1 file changed, 13 insertions(+)
> > >
> > > @@ -3635,6 +3641,8 @@ static int hv_pci_probe(struct hv_device *hdev,
> > >
> > > retry:
> > > ret = hv_pci_query_relations(hdev);
> > > + printk("hv_pci_query_relations() exited\n");
> >
> > Can we use pr_* or the appropriate KERN_<LEVEL> in all the printk(s).
>
> This is not part of the real patch :-)
> I just thought the debug code can help understand the issues
> resolved by the patches.
> I'll remove the debug code to avoid confusion if I need to post v2.
I guess that means you *will* post a v2, right? Or do you expect
somebody else to remove the debug code? If you do keep any debug or
other logging, use pci_info() (or dev_info()) whenever possible.
Also capitalize the subject line to match the others in the series.
Bjorn
