On Mon, Jan 16, 2023 at 02:11:29AM +0000, lizhijian@xxxxxxxxxxx wrote: > > +/** > > + * rxe_mr_do_atomic_write() - write 64bit value to iova from addr > > + * @mr: memory region > > + * @iova: iova in mr > > + * @addr: source of data to write > > + * > > + * Returns: > > + * 0 on success > > + * -1 for misaligned address > > + * -2 for access errors > > + * -3 for cpu without native 64 bit support > > Well, i'm not favor of such error code. especialy when it's not a staic subroutine. > Any comments from other maintainers ? It should at least have proper constants, but can it be structured to avoid this in the first place? Jason
